feat(scan_layers): verify scan_layers compatibility from checkpoint metadata#4304
Open
RexBearIU wants to merge 1 commit into
Open
feat(scan_layers): verify scan_layers compatibility from checkpoint metadata#4304RexBearIU wants to merge 1 commit into
RexBearIU wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
0330b0a to
c0718c2
Compare
c0718c2 to
f407634
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This PR is based on #4269.
This PR introduces proactive validation of
scan_layersconfiguration compatibility when loading checkpoint metadata in MaxText.Key changes:
scan_layersin Custom Metadata: Updatedsave_checkpointinsrc/maxtext/common/checkpointing.pyto write thescan_layersconfiguration parameter to checkpoint custom metadata.from_pretrainedfunction insrc/maxtext/utils/model_creation_utils.pyto compare the savedscan_layersvalue against the running configuration, raising a descriptiveValueErroron mismatch to prevent silent model structure mismatches.tests/post_training/unit/lora_utils_test.pyto assert specifically on the"lora"key incustom_metadatainstead of full dict equality, decoupling LoRA assertions from global metadata additions.tests/unit/model_creation_utils_test.pyto verify matching, mismatching, and missingscan_layersmetadata scenarios.Tests
Tested this change by running the unit tests for both
model_creation_utils_test.pyandlora_utils_test.pyunder the CPU platform:Output:
74 passedChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.